[FPSan] implement cosine and sine#10005
Merged
Merged
Conversation
These now obey the usual algebraic properties, namely the angle sum identities, reflection formulae, and the sin(x)^2 + cos(x)^2 == 1 norm condition. This is accomplished by taking the coefficients of (-3/5 + 4/5 i)^x in the quadratic extension of the payload domain by a formal symbol i satisfying i^2 == -1.
ptillet
approved these changes
Apr 11, 2026
plognjen
pushed a commit
to plognjen/triton
that referenced
this pull request
Apr 14, 2026
These now obey the usual algebraic properties, namely the trigonometric angle sum identities, reflection formulae, and the `sin(x)^2 + cos(x)^2 == 1` norm condition. Unit tests are included to verify these. This is accomplished by taking the coefficients of `(-3/5 + 4/5 i)^x` in the quadratic extension of the payload domain by a formal symbol `i` satisfying `i^2 == -1`.
raymondtay
pushed a commit
to raymondtay/triton
that referenced
this pull request
Apr 18, 2026
These now obey the usual algebraic properties, namely the trigonometric angle sum identities, reflection formulae, and the `sin(x)^2 + cos(x)^2 == 1` norm condition. Unit tests are included to verify these. This is accomplished by taking the coefficients of `(-3/5 + 4/5 i)^x` in the quadratic extension of the payload domain by a formal symbol `i` satisfying `i^2 == -1`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These now obey the usual algebraic properties, namely the trigonometric angle sum identities, reflection formulae, and the
sin(x)^2 + cos(x)^2 == 1norm condition. Unit tests are included to verify these.This is accomplished by taking the coefficients of
(-3/5 + 4/5 i)^xin the quadratic extension of the payload domain by a formal symbolisatisfyingi^2 == -1.