[FPSAN] Fix an issue where tmem writes in WS may get dropped#10000
Merged
pawelszczerbuk merged 3 commits intoApr 13, 2026
Conversation
ptillet
approved these changes
Apr 11, 2026
Contributor
|
10000!! |
plognjen
pushed a commit
to plognjen/triton
that referenced
this pull request
Apr 14, 2026
…lang#10000) Fpsan emulates tmem with global scratch. Each tmem buffer is being mapped to a scratch allocation. There was an issue in how the mapping was created for WS partitions, with the same tmem buffer being mapped to distinct scratch allocations. We track the "canonical" tmem allocation now, to make sure that tmem aliases in different regions, even though they are represented by different SSA values, are getting mapped to the original allocation correctly. --------- Co-authored-by: root <root@codex-gb200-0.brix.pawelszczerbuk.svc.cluster.local>
raymondtay
pushed a commit
to raymondtay/triton
that referenced
this pull request
Apr 18, 2026
…lang#10000) Fpsan emulates tmem with global scratch. Each tmem buffer is being mapped to a scratch allocation. There was an issue in how the mapping was created for WS partitions, with the same tmem buffer being mapped to distinct scratch allocations. We track the "canonical" tmem allocation now, to make sure that tmem aliases in different regions, even though they are represented by different SSA values, are getting mapped to the original allocation correctly. --------- Co-authored-by: root <root@codex-gb200-0.brix.pawelszczerbuk.svc.cluster.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fpsan emulates tmem with global scratch. Each tmem buffer is being mapped to a scratch allocation. There was an issue in how the mapping was created for WS partitions, with the same tmem buffer being mapped to distinct scratch allocations. We track the "canonical" tmem allocation now, to make sure that tmem aliases in different regions, even though they are represented by different SSA values, are getting mapped to the original allocation correctly.