-
Notifications
You must be signed in to change notification settings - Fork 11
Populate PluginInfo::tritonVersion + CI smoke test #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
1d7b748
utlx: populate PluginInfo::tritonVersion (fixes plugin load on curren…
wychi 47debef
ci: add plugin-import smoke test
wychi 44ba85b
ci: convert plugin-import smoke test to pytest integration test
wychi 6e9d25d
utlx: drop doc comment from PluginInfo initializer
wychi 4772f44
ci: apply yapf to test_plugin_imports.py
wychi bc7cf40
ci: source venv before running tests
wychi bb21492
ci: add plugin scenario tests using prebuilt triton from artifact
wychi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a decent test: "does the plugin load?" But this would be more valuable as an integration test (e.g., using
pytest) that loads every plugin registered in this repository to make sure each plugin can be loaded. Then whatever command is necessary to run the test could be added tomake test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and I guess from the CI failure that we don't really have a virtual environment set up with Triton installed, so that might be needed as well.