You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these rules.
I have run pre-commit run --from-ref origin/main --to-ref HEAD.
Select one of the following.
I have added tests.
/test for lit tests
/unittest for C++ tests
/python/test for end-to-end tests
This PR does not need a test because FILL THIS IN.
Select one of the following.
I have not added any lit tests.
The lit tests I have added follow these best practices,
including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)
⚠️ GitHub could not post this as an inline comment: No line information provided
The constructor previously skipped block IDs where blockId <= 0, filtering out both zero and negative values. The new code uses if (auto blockId = blockIdAttr.getInt()) which only skips zero (falsy) but now accepts negative block IDs. This is problematic because -1 is used throughout the codebase as a special sentinel value for 'no block ID' (getBlockIdByOp returns -1 as 'not found', updateBlockId treats -1 as 'remove attribute'). Accepting negative block IDs into the manager could lead to incorrect lookups or collisions with the sentinel value.
⚠️ GitHub could not post this as an inline comment: No line information provided
The condition for identifying cube operations has changed from isCubeSimpleOpOrCf (which walked into region-branch ops to check child ops' core types) to isCubeOp (which rejects all SCF ops entirely). The old isCubeSimpleOpOrCf was specifically designed to handle RegionBranchOpInterface ops by inspecting their inner ops. The new isCubeOp returns false for any SCF op, including those that may contain only CUBE_ONLY operations. This changes the set of ops recognized as "cube", potentially causing scheduling failures for cube code wrapped in SCF control flow.
⚠️ GitHub could not post this as an inline comment: Line 11 could not be resolved (outside PR diff hunks)
The module-level docstring (line 11) says 'ensure the MLIR code contains the "scope" keyword', which contradicts the new assertion that expects 'scope' NOT to be present. This should be updated to describe the new fallback-scenario validation (scope should NOT be present).
💡 Suggested Change
Before:
3. Add MLIR content validation in test functions to ensure the MLIR code contains the "scope" keyword
After:
3. Add MLIR content validation in test functions to ensure the MLIR code does NOT contain the "scope" keyword in fallback scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascend-backendChanges to the Ascend NPU backendcompilerChanges to C/C++ compiler backend (lib/, include/)pythonChanges to Python runtime or bindings
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e9a0f9c.
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)