Skip to content

[build](fix) delete submodule Triton-distributed-ascend #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KanuaK merged 1 commit into from
Aug 13, 2026
+22 −12
Merged

[build](fix) delete submodule Triton-distributed-ascend #1530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,3 @@
path = third_party/ascend/AscendNPU-IR
url = https://gitcode.com/Ascend/AscendNPU-IR.git
depth = 1
[submodule "third_party/ascend/Triton-distributed-ascend"]
path = third_party/ascend/Triton-distributed-ascend
url = https://gitcode.com/Ascend/Triton-distributed-ascend.git
30 changes: 22 additions & 8 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,7 @@ def build_extension(self, ext):
else:
cmake_args += ["-DTRITON_BUILD_PROTON=OFF"]

if check_env_flag("TRITON_BUILD_DISTRIBUTED", "ON"):
if check_env_flag("TRITON_BUILD_DISTRIBUTED", "OFF"):
cmake_args += ["-DTRITON_BUILD_DISTRIBUTED=ON"]
else:
cmake_args += ["-DTRITON_BUILD_DISTRIBUTED=OFF"]
Expand Down Expand Up @@ -609,14 +609,28 @@ def is_git_repo():


def ensure_distributed_submodule():
if not check_env_flag("TRITON_BUILD_DISTRIBUTED", "ON"):
if not check_env_flag("TRITON_BUILD_DISTRIBUTED", "OFF"):
return
distributed_dir = Path(triton_dir) / "third_party" / "ascend" / "Triton-distributed-ascend"
if not (distributed_dir / "CMakeLists.txt").is_file() and is_git_repo():
if not distributed_dir.is_dir():
Comment thread
LH-123L marked this conversation as resolved.
subprocess.check_call([
"git", "submodule", "update", "--init", "--",
"third_party/ascend/Triton-distributed-ascend"
], cwd=triton_dir)
"git",
"clone",
"https://gitcode.com/Ascend/Triton-distributed-ascend.git",
"-b",
"release/3.2.2",
], cwd=Path(triton_dir) / "third_party" / "ascend")
if is_git_repo():
subprocess.check_call([
"git",
"checkout",
"release/3.2.2",
Comment thread
LH-123L marked this conversation as resolved.
], cwd=distributed_dir)
subprocess.check_call([
"git",
"pull",
"origin",
], cwd=distributed_dir)
Comment thread
LH-123L marked this conversation as resolved.
if not (distributed_dir / "CMakeLists.txt").is_file():
raise RuntimeError(f"Triton-Distributed submodule is not initialized: {distributed_dir}")

Expand Down Expand Up @@ -735,7 +749,7 @@ def add_links():
add_link_to_backends()
if check_env_flag("TRITON_BUILD_PROTON", "ON"): # Default ON
add_link_to_proton()
if check_env_flag("TRITON_BUILD_DISTRIBUTED", "ON"):
if check_env_flag("TRITON_BUILD_DISTRIBUTED", "OFF"):
add_link_to_distributed()


Expand Down Expand Up @@ -841,7 +855,7 @@ def get_packages():
packages += get_language_extra_packages()
if check_env_flag("TRITON_BUILD_PROTON", "ON"): # Default ON
packages += ["triton/profiler"]
if check_env_flag("TRITON_BUILD_DISTRIBUTED", "ON"):
if check_env_flag("TRITON_BUILD_DISTRIBUTED", "OFF"):
distributed_root = os.path.join(os.pardir, "third_party", "ascend", "Triton-distributed-ascend", "python")
distributed_pkg_root = os.path.join(distributed_root, "triton_dist")
if os.path.isdir(distributed_pkg_root):
Expand Down
1 change: 0 additions & 1 deletion third_party/ascend/Triton-distributed-ascend
Open in desktop
Submodule Triton-distributed-ascend deleted from 24036f
Loading