-
Notifications
You must be signed in to change notification settings - Fork 184
[ssbuffer](feat) scalar v2c dep fix v2 #1521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-dev
Are you sure you want to change the base?
Changes from all commits
cc1e03a
40e0cbe
e4470c8
874d73b
844afc3
a6fcf38
9a7e104
ccc26a3
ba58e92
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -144,6 +144,13 @@ class DataDependencyAnalysisPass | |||||||||||||||||||||||
| mlir::Operation *predOp, mlir::Operation *nextOp); | ||||||||||||||||||||||||
| void analyzeExternalInputs(DataDependencyInfo &info); | ||||||||||||||||||||||||
| void analyzeExternalOutputs(DataDependencyInfo &info); | ||||||||||||||||||||||||
| void analyzeScalarVToCDependencies(DataDependencyInfo &info); | ||||||||||||||||||||||||
| void analyzeScalarExtractDependencies( | ||||||||||||||||||||||||
| DataDependencyInfo &info, | ||||||||||||||||||||||||
| llvm::DenseSet<mlir::Value> &handledScalarValues); | ||||||||||||||||||||||||
| void analyzeScalarControlFlowDependencies( | ||||||||||||||||||||||||
| DataDependencyInfo &info, | ||||||||||||||||||||||||
| llvm::DenseSet<mlir::Value> &handledScalarValues); | ||||||||||||||||||||||||
|
Comment on lines
+148
to
+153
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [maintainability · low] Suggestion:
Suggested change
|
||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
| void analyzeMemoryEffect(DataDependencyInfo &info); | ||||||||||||||||||||||||
| std::pair<int, int> findCommonLevelBlockIds(DataDependencyInfo &info, | ||||||||||||||||||||||||
|
|
||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[maintainability · low]
The
createPointerCastOpconvenience function silently defaults to i32 element type. While the comment documents this assumption and all current callers inUpdateConditionInfo.cppindeed store i32 values, there is no compile-time or runtime guard against misuse. A future developer adding a new caller could unintentionally create a type-mismatchedmemref::StoreOp(which verifies value type matches memref element type).Suggestion: Add an overload that accepts an explicit element type parameter, making the API symmetric with
getSsbufConstAndPointerCast. This would also make the function more discoverable for developers who need non-i32 scalar types.Suggestion: