Main dev load - #1519
Conversation
Co-Authored-By: Claude <noreply@anthropic.com>
|
🔍 OpenCodeReview found 1 issue(s) in this PR.
|
| if (isSdpaInferKernel) { | ||
| LOG_DEBUG("kernel _sdpa_infer_kernel: skip GM load marking"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
[maintainability · medium]
The log message always says "kernel _sdpa_infer_kernel" regardless of which function name triggered the early return. When the match is for "kernel_sdpa_fwd", the log message becomes misleading and would hinder debugging.
Suggestion:
| if (isSdpaInferKernel) { | |
| LOG_DEBUG("kernel _sdpa_infer_kernel: skip GM load marking"); | |
| return; | |
| } | |
| if (isSdpaInferKernel) { | |
| LOG_DEBUG("skip GM load marking for sdpa infer kernel"); | |
| return; | |
| } |
a1249e9 to
ab9b991
Compare
| return WalkResult::advance(); | ||
| }); | ||
| if (isSdpaInferKernel) { | ||
| LOG_DEBUG("kernel _sdpa_infer_kernel: skip GM load marking"); |
There was a problem hiding this comment.
[bug · low]
The log message only mentions _sdpa_infer_kernel but the condition also matches kernel_sdpa_fwd. If the module contains kernel_sdpa_fwd (but not _sdpa_infer_kernel), this log message would be misleading—it would print "kernel _sdpa_infer_kernel: skip GM load marking" even though the actual matching function is kernel_sdpa_fwd. Consider making the log message generic or dynamically including the matched function name.
Suggestion:
| LOG_DEBUG("kernel _sdpa_infer_kernel: skip GM load marking"); | |
| LOG_DEBUG("skip GM load marking for sdpa kernel"); |
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD.Select one of the following.
/testforlittests/unittestfor C++ tests/python/testfor end-to-end testsFILL THIS IN.Select one of the following.
littests.littests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)