Skip to content

Conversation

@verdie-g
Copy link

What does the PR do?

OpenTelemetry tracing in Triton only supports one sampling option which is the rate. OpenTelemetry defines some standard samplers. Here I would like to support something close to the popular ParentBased. The sampling decision from the tracing header is used, otherwise a root sampler is used, in our case the rate option.

Checklist

  • I have read the Contribution guidelines and signed the Contributor License
    Agreement
  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • I ran pre-commit locally (pre-commit install, pre-commit run --all)
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

Where should the reviewer start?

Test plan:

Caveats:

Background

I'm trying to have complete traces in my infrastructure but Triton completely ignores the sampling decision of the parent.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

@verdie-g
Copy link
Author

@GuanLuo could you tell me what you think about this solution? Then I'll work on the testing part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant