Skip to content

Conversation

@indrajit96
Copy link
Contributor

What does the PR do?

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Related PRs:

This is test coverage for #7839

Where should the reviewer start?

test.sh

Test plan:

Load a trt-llm model
Pass orca header in request
Verify orca metrics in response

@BenjaminBraunDev
Copy link
Contributor

Quick thing to note: I just renamed the request header to specify the ORCA format from endpoint-load-metrics-type to endpoint-load-metrics-format

@indrajit96 indrajit96 merged commit 422527d into main Mar 17, 2025
3 checks passed
@indrajit96 indrajit96 deleted the ibhosale_L0_orca branch March 17, 2025 07:02
ziqifan617 pushed a commit that referenced this pull request Mar 21, 2025
mc-nv pushed a commit that referenced this pull request Apr 1, 2025
mc-nv added a commit that referenced this pull request Apr 1, 2025
@yinggeh yinggeh mentioned this pull request May 8, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants