Fix bad unsafe cast when unwrapping a COMEmbedding (#455)

tristanlabelle · Jan 1, 2025 · 97798e1 · 97798e1
1 parent a5da873
commit 97798e1
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/Support/Sources/COM/COMEmbedding+statics.swift b/Support/Sources/COM/COMEmbedding+statics.swift
@@ -64,12 +64,13 @@ extension COMEmbedding {
     public static func getImplementer<ABIStruct, Implementer>(
             _ this: UnsafeMutablePointer<ABIStruct>, type: Implementer.Type = Implementer.self) -> Implementer? {
         do {
-            _ = try COMInterop(this).queryInterface(uuidof(SWRT_COMEmbedding.self))
+            let comEmbeddingRefeference = try COMInterop(this).queryInterface(uuidof(SWRT_COMEmbedding.self))
+            // Use the resulting pointer and not "this" since in COM aggregation cases,
+            // "this" might be a non-Swift COM object.
+            return getImplementerUnsafe(comEmbeddingRefeference.pointer, type: type)
         } catch {
             return nil
         }
-
-        return getImplementerUnsafe(this, type: type)
     }
 }