Swift 5 and package manager support to be able to SPM AlamofireObjectMapper #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
travis doesn't run for PR ? adding maybe adding linux support in SPM / travis should also be added (as another PR) |
kenji21
referenced
this pull request
in openium/AlamofireObjectMapper
May 14, 2020
|
Hey, I've fixed the Travis integration so it should work now. Can you please merge master as I've merged a PR to upgrade to swift 5 |
|
Just done it, waiting travis feedback |
|
Just updated SPM configuration line in README.md |
tristanhimmelman
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I want to add SPM support for AlamofireObjectMapper (tristanhimmelman/AlamofireObjectMapper#305)
So I need to be able to
swift buildand alsoswift testRelated issues: #1082 and #1089
What
Cherry-picked 4 commits from #1081, thanks to @emrcftci
Removed Sources symlink and fixed Package.swift to mark it Swift 5 (otherwise, it is swift 3... and the path to sources can't be customised)
Added test target in Package.swift to be able to
swift testFound 176 macOS tests while having 174 when runner with the xcworkspace (URLTransformTests were missing to macOS and tvOS test targets)