Add default argument to Map's value(_)
#1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update Swift version to 5 - XCode automaticly created IDEWorkspaceChecks.plist after update it - Delete SWIFT_SWIFT3_OBJC_INFERENCE from project.pbxproj
- Fix `hashValue` to `hasher(into: )` in MappableExtensionsTests.swift - Fix warnings related to `try?` declaration in ImmutableTests, MapContextTests, PerformanceTests
…both `hasher.combine(_)` lines
|
Could you please check? @tristanhimmelman |
|
I'm ok with this PR, but you will need to rebase master and get the tests passing again in Travis |
Merge master to emrcftci/master
…jectMapper into feature/defaultValue
- Revert accidently created commit from another pull-request -> tristanhimmelman#1081
I've rebased master into my branch but I accidentally take some commits from my other pull-request(#1081). So I've reverted these unwanted commits. Sorry for the mistake. |
|
No worries @emrcftci! Thanks for the contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
defaultvalue as an argument to Map'svalue(_)We can assign default value effortlessly with this new feature.
Motivation and Context
We will be use
defaultargument for assign default value,We will avoid using parentheses for assign default values
after this pull-request merge.
What kind of change does this PR introduce?