Ubdate to Swift 5.0 #1066
Open
Ubdate to Swift 5.0 #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emrcftci
reviewed
Jan 24, 2020
| @@ -272,7 +272,7 @@ public extension Mapper where N: ImmutableMappable { | |||
| #if swift(>=4.1) | |||
| return try JSONArray.compactMap(mapOrFail) | |||
| #else | |||
| return try JSONArray.flatMap(mapOrFail) | |||
| return try JSONArray.compactMap(mapOrFail) | |||
There was a problem hiding this comment.
Please just remove else statement if it is necessary because now if and else blocks has same actions.
emrcftci
reviewed
Jan 24, 2020
| @@ -134,7 +134,7 @@ public final class Map { | |||
| #if swift(>=4.1) | |||
| return v.compactMap{ Float($0) } as? T | |||
| #else | |||
| return v.flatMap{ Float($0) } as? T | |||
| return v.compactMap{ Float($0) } as? T | |||
There was a problem hiding this comment.
Same comment as above.
Please just remove else statement if it is necessary because now if and else blocks has same actions.
emrcftci
reviewed
Jan 24, 2020
| @@ -165,7 +165,7 @@ public final class Mapper<N: BaseMappable> { | |||
| #if swift(>=4.1) | |||
| let result = JSONArray.compactMap(map) | |||
| #else | |||
| let result = JSONArray.flatMap(map) | |||
| let result = JSONArray.compactMap(map) | |||
There was a problem hiding this comment.
Same comment as above.
Please just remove else statement if it is necessary because now if and else blocks has same actions.
emrcftci
reviewed
Jan 24, 2020
| @@ -433,7 +433,7 @@ extension Mapper where N: Hashable { | |||
| #if swift(>=4.1) | |||
| return Set(JSONArray.compactMap(map)) | |||
| #else | |||
| return Set(JSONArray.flatMap(map)) | |||
| return Set(JSONArray.compactMap(map)) | |||
There was a problem hiding this comment.
Same comment as above.
Please just remove else statement if it is necessary because now if and else blocks has same actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the code to Swift 5.0