Refactor some array (and map) functions#9905
Merged
findepi merged 8 commits intotrinodb:masterfrom Nov 23, 2021
Merged
Conversation
Merged
jirassimok
force-pushed
the
refactor-array-functions
branch
2 times, most recently
from
818a83a to
8a63b7e
Compare
jirassimok
force-pushed
the
refactor-array-functions
branch
from
8a63b7e to
15403eb
Compare
Instead of allocating an extra BlockBuilder and manually checking if elements are in the TypedSet, use the same BlockBuilder for the set and add the elements once instead of twice.
findepi
force-pushed
the
refactor-array-functions
branch
from
15403eb to
2dda7af
Compare
Member
|
Rebased after #9901 merged. |
findepi
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #9901; the changes in
TypedSetbelong to that PR.