Print error when DateTimeZoneIndex init with failure for debug#9758
Merged
findepi merged 1 commit intotrinodb:masterfrom Apr 4, 2022
Merged
Print error when DateTimeZoneIndex init with failure for debug#9758findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
findepi
reviewed
Oct 26, 2021
Member
There was a problem hiding this comment.
Exception must be propagated, otherwise the class will be loaded and appear as fully initialized, despite not being so.
`DateTimeZoneIndex` init may fail when running tests (locally, or on the CI) and the static initializer failure is not always nicely shown. Log to increase visibility.
findepi
force-pushed
the
zhoukang/improve-date-log
branch
from
2a45fa1 to
5b133a2
Compare
findepi
added
test
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateTimeZoneIndex may init with failure, for example:
and then we may get
We should print the failure message as log for quick debugging.