Skip to content

Document ALTER TABLE EXECUTE commands#9682

Merged
losipiuk merged 1 commit intotrinodb:masterfrom
jhlodin:jl/alter-table-cmd
Oct 28, 2021
Merged

Document ALTER TABLE EXECUTE commands#9682
losipiuk merged 1 commit intotrinodb:masterfrom
jhlodin:jl/alter-table-cmd

Conversation

@jhlodin
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin commented Oct 18, 2021

Add documentation for the ALTER TABLE <name> EXECUTE <cmd> WITH <parameters> statement, starting with OPTIMIZE but laying groundwork for additional commands.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The part about OPTIMIZE should go to Hive documentation.
The alter-table page should just note that there is mechanism to execute table procedures/commands (nomenclature to be defined); and that different procedures are provided by different connectors.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and changed. Will any other connectors support EXECUTE OPTIMIZE or any other commands on 364?

@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from 6874f58 to b0735e2 Compare October 19, 2021 13:35
@jhlodin jhlodin added the docs label Oct 19, 2021
@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from b0735e2 to 924584b Compare October 19, 2021 16:25
Copy link
Copy Markdown
Member

@Ordinant Ordinant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@losipiuk
Copy link
Copy Markdown
Member

I added changes to adjust PR to syntax change.

@losipiuk
Copy link
Copy Markdown
Member

I also added a safety note. Please make it more English @jhlodin :)

@losipiuk
Copy link
Copy Markdown
Member

cc: @findepi

@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from 27cc471 to 22ad6d4 Compare October 26, 2021 15:43
@jhlodin
Copy link
Copy Markdown
Contributor Author

jhlodin commented Oct 26, 2021

@losipiuk @findepi Edited your note a bit, PTAL and make sure I didn't make it inaccurate. If it looks good, would be great to get this squashed+merged soon so it's in before 364 is cut.

@jhlodin jhlodin force-pushed the jl/alter-table-cmd branch from 22ad6d4 to 7a4ed33 Compare October 26, 2021 19:43
@losipiuk losipiuk merged commit 4152a0f into trinodb:master Oct 28, 2021
@github-actions github-actions bot added this to the 364 milestone Oct 28, 2021
@jhlodin jhlodin deleted the jl/alter-table-cmd branch October 28, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants