Flatten Iceberg catalog/metastore configuration#9577
Merged
findepi merged 2 commits intotrinodb:masterfrom Oct 12, 2021
Merged
Conversation
findepi
requested review from
alexjo2144,
electrum,
hashhar,
jackye1995,
losipiuk and
martint
losipiuk
approved these changes
Oct 11, 2021
Hive metastore is not sufficient abstraction for Iceberg, since locking protocol will be different for different `HiveMetastore` implementations. Flattening configuration allows us to clearly define what catalogs are supported, and also reduces configuration complexity from end user perspective. This removes use of `hive.metastore` config from Iceberg in favor of already existing `iceberg.catalog.type`.
findepi
force-pushed
the
findepi/catalog-metastore-type
branch
from
10eac8e to
8d3eb27
Compare
hashhar
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hive metastore is not sufficient abstraction for Iceberg, since locking
protocol will be different for different
HiveMetastoreimplementations. Flattening configuration allows us to clearly define
what catalogs are supported, and also reduces configuration complexity
from end user perspective.
This removes use of
hive.metastoreconfig from Iceberg in favor ofalready existing
iceberg.catalog.type.