Add support for RLE blocks to BigintGroupByHash#9510
Merged
sopel39 merged 3 commits intotrinodb:masterfrom Oct 5, 2021
Merged
Conversation
with pollution BenchmarkGroupByHash.bigintGroupByHash 1 true avgt 20 121,234 ± 3,798 ns/op without pollution BenchmarkGroupByHash.bigintGroupByHash 1 true avgt 20 97,325 ± 1,945 ns/op
Reduces Block pollution to BenchmarkGroupByHash.bigintGroupByHash 1 true avgt 20 102,521 ± 1,203 ns/op from BenchmarkGroupByHash.bigintGroupByHash 1 true avgt 20 121,234 ± 3,798 ns/op
sopel39
commented
Oct 5, 2021
| } | ||
| } | ||
|
|
||
| private class AddRunLengthEncodedPageWork |
Member
Author
There was a problem hiding this comment.
this is based on io.trino.operator.MultiChannelGroupByHash.AddRunLengthEncodedPageWork code
losipiuk
reviewed
Oct 5, 2021
core/trino-main/src/test/java/io/trino/operator/BenchmarkGroupByHash.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 5, 2021
core/trino-main/src/test/java/io/trino/operator/BenchmarkGroupByHash.java
Show resolved
Hide resolved
losipiuk
reviewed
Oct 5, 2021
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
Main logic LGTM. Come comments still.
sopel39
added a commit
that referenced
this pull request
Oct 6, 2021
Addressing comment from #9510 which was ommited by mistake
sumeethkc
pushed a commit
to sumeethkc/trino
that referenced
this pull request
Nov 11, 2021
Addressing comment from trinodb#9510 which was ommited by mistake
sumannewton
pushed a commit
to sumannewton/trino
that referenced
this pull request
Jan 17, 2022
Addressing comment from trinodb#9510 which was ommited by mistake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.