Minor cleanups in SqlFormatter

[losipiuk]

No description provided.

[martint]

What’s the purpose of those assertions? Indent can’t be anything other than 0 already, since that’s how the visitor gets called in the first place, and it’s private to this class, so it can’t be misused.

[findepi]

checkArgument? (and below)

[losipiuk]

Yeah. Sequence of private methods fooled me. We are already past public interface.

[losipiuk]

What’s the purpose of those assertions? Indent can’t be anything other than 0 already, since that’s how the visitor gets called in the first place, and it’s private to this class, so it can’t be misused.

Just a sanity check. It is not obvious from the code flow that we can not land in the visitXXX method which ignores indent param as a result of calling out to process(currentNode.getSomething(), indent + 1).
If that would be the case we would end up with misformatted SQL - having an error is better IMO.

[losipiuk]

I dropped checks as thy do play well with PREPARE ...