Extract JDBC write-related configuration to separate class#9322
Merged
hashhar merged 1 commit intotrinodb:masterfrom Sep 23, 2021
Merged
Extract JDBC write-related configuration to separate class#9322hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
wendigo
force-pushed
the
serafin/refactor-jdbc-write-config
branch
from
0ae26b7 to
200c930
Compare
sergey-melnychuk
approved these changes
Sep 21, 2021
Member
|
Phoenix failure is related. Phoenix has it's own module IIRC. |
wendigo
force-pushed
the
serafin/refactor-jdbc-write-config
branch
from
200c930 to
9119872
Compare
Member
|
What is the motivation? |
Member
|
findepi
approved these changes
Sep 22, 2021
Member
|
CI #5892 & sth else |
Member
hashhar
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8434 (comment)