Refactor task scheduling related components #9294
Closed
arhimondr wants to merge 1 commit intotrinodb:masterfrom
Closed
Refactor task scheduling related components #9294arhimondr wants to merge 1 commit intotrinodb:masterfrom
arhimondr wants to merge 1 commit intotrinodb:masterfrom
Conversation
d165d81 to
1dc1791
Compare
This is a preparation for introducing task level retries. This PR removes "all-or-nothing" execution assumption from SqlStageExecution. Scheduling related assumptions of streaming execution are now moved to the StreamingStageExecution. SqlStageExecution is now merely a container for scheduled tasks for a particular stage. It's main responsibility now is to keep track of running tasks and collect their execution statistics.
1dc1791 to
00fbfc8
Compare
Contributor
Author
|
Closing in favor of #9361 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a preparation for introducing task level retries.
This PR removes "all-or-nothing" execution assumption from
SqlStageExecution.Scheduling related assumptions of streaming execution are now moved to
the
StreamingStageExecution.SqlStageExecutionis now merely a containerfor scheduled tasks for a particular stage. It's main responsibility now
is to keep track of running tasks and collect their execution
statistics.
For #2909