Fix distinct aggregation input filtering when input mask has nulls#9265
Merged
martint merged 1 commit intotrinodb:masterfrom Sep 16, 2021
Merged
Conversation
pettyjamesm
force-pushed
the
distinct-accumulator-null-mask
branch
from
178c5e5 to
890c2fe
Compare
Similar to trinodb#2267 the distinct accumulator filtering checks were not checking for nulls in the input mask rows.
pettyjamesm
force-pushed
the
distinct-accumulator-null-mask
branch
from
890c2fe to
6d34fd7
Compare
pettyjamesm
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #2267, distinct accumulators were not checking for nulls in their input masks, which might allow null positions to pass the filter check incorrectly.
Comparable changes to prestodb/presto#16747