Fix in clause handling of varchars in filter pushdown#9181
Merged
hashhar merged 1 commit intotrinodb:masterfrom Sep 9, 2021
Merged
Fix in clause handling of varchars in filter pushdown#9181hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
elonazoulay
force-pushed
the
fix_in_clause_filter
branch
from
e13c51f to
b475fd8
Compare
hashhar
approved these changes
Sep 9, 2021
Member
There was a problem hiding this comment.
LGTM.
@elonazoulay Can you please add a "Fixes #xxx" to the PR description (would help when adding release notes).
| else if (type instanceof VarcharType) { | ||
| return ((Slice) value).toStringUtf8(); | ||
| } | ||
| return value; |
Member
There was a problem hiding this comment.
In future we should handle all types explicitly here to avoid surprises.
Member
Author
There was a problem hiding this comment.
sounds good, will do!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In and not in clauses did not handle varchar correctly.
Fixes #9133