Use ID-based mapping for struct fields in Iceberg Parquet reader vol. 2#9124
Merged
findepi merged 5 commits intotrinodb:masterfrom Sep 7, 2021
Merged
Use ID-based mapping for struct fields in Iceberg Parquet reader vol. 2#9124findepi merged 5 commits intotrinodb:masterfrom
findepi merged 5 commits intotrinodb:masterfrom
Conversation
- cast after `instanceof` check - convert use of `getTypeParameters` to direct use of type's attributes - `Optional.get` -> `Optional.orElseThrow`
- rename `ParquetColumnIOConverter` to `HiveParquetColumnIOConverter` - the new class `IcebergParquetColumnIOConverter` is a copy of `ParquetColumnIOConverter`, with only class name changed.
findepi
commented
Sep 6, 2021
| return null; | ||
| } | ||
|
|
||
| @Nullable |
Member
Author
There was a problem hiding this comment.
Not pretty, but consistent with other methods in this file. A change to Optional can be a follow up, if needed.
Member
Author
|
Conflicts with #8129, but @alexjo2144 mentioned to me he and @phd3 concluded this should go before dereference pushdown. |
This was referenced Sep 7, 2021
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like #9104 but with splitting
ParquetColumnIOConverterinstead of refactoring it.Fixes #8750