[WIP] Always consume guaranteed limit on pushDown#9056
Closed
losipiuk wants to merge 1 commit intotrinodb:masterfrom
Closed
[WIP] Always consume guaranteed limit on pushDown#9056losipiuk wants to merge 1 commit intotrinodb:masterfrom
losipiuk wants to merge 1 commit intotrinodb:masterfrom
Conversation
losipiuk
changed the title
findepi
reviewed
Aug 31, 2021
| if (!limitGuaranteed) { | ||
| return Optional.empty(); | ||
| } | ||
| return Optional.of(new LimitApplicationResult<>(handle, limitGuaranteed, false)); |
Member
There was a problem hiding this comment.
connector should return non-empty only when plan changes.
per io.trino.spi.connector.ConnectorMetadata#applyLimit doc:
* Connectors can indicate whether they don't support limit pushdown or that the action had no effect
* by returning {@link Optional#empty()}.
Member
There was a problem hiding this comment.
I think instead, we would need "redundant limit pruning rule"
i.e. a connector needs to be able to tell the engine what's the max cardinality to be returned
(just like it can return enforced predicates)
Member
|
👋 @losipiuk - this PR has become inactive. We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks. |
Member
|
Closing this one out due to inactivity, but please reopen if you would like to pick this back up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.