Skip to content

mongodb add note for explicitly quoting fields when manually setting schema#9019

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
academy-codex:mr_mongodb_docs_field_quote_example
Apr 28, 2022
Merged

mongodb add note for explicitly quoting fields when manually setting schema#9019
ebyhr merged 1 commit intotrinodb:masterfrom
academy-codex:mr_mongodb_docs_field_quote_example

Conversation

@academy-codex
Copy link
Contributor

Fixes #5353

@cla-bot cla-bot bot added the cla-signed label Aug 28, 2021
@academy-codex academy-codex requested a review from hashhar August 28, 2021 21:19
@ebyhr ebyhr added the docs label Aug 29, 2021
@ebyhr ebyhr requested a review from m57lyra August 29, 2021 04:53
@findepi findepi requested a review from ebyhr August 29, 2021 19:45
@ebyhr
Copy link
Member

ebyhr commented Aug 30, 2021

The commit message is too long. Please change to "Document type example of field quotation in MongoDB".
https://github.com/trinodb/trino/blob/master/DEVELOPMENT.md#format-git-commit-messages

@academy-codex academy-codex force-pushed the mr_mongodb_docs_field_quote_example branch from de96038 to 7908e31 Compare August 30, 2021 08:07
@academy-codex
Copy link
Contributor Author

The commit message is too long. Please change to "Document type example of field quotation in MongoDB".
https://github.com/trinodb/trino/blob/master/DEVELOPMENT.md#format-git-commit-messages

Done :)

@hashhar hashhar requested a review from mosabua September 3, 2021 18:55
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update and verify that it builds locally.

@academy-codex academy-codex force-pushed the mr_mongodb_docs_field_quote_example branch from 7908e31 to be15985 Compare March 6, 2022 15:13
@academy-codex
Copy link
Contributor Author

@ebyhr @mosabua Please review if the review comments are addressed. Thanks :)

@academy-codex academy-codex requested review from ebyhr and mosabua March 6, 2022 15:17
@ebyhr ebyhr assigned mosabua and unassigned academy-codex Mar 9, 2022
@mosabua mosabua removed the request for review from m57lyra March 25, 2022 21:15
@mosabua
Copy link
Member

mosabua commented Apr 26, 2022

Can we help with progressing this somehow?

@ebyhr ebyhr force-pushed the mr_mongodb_docs_field_quote_example branch from be15985 to e079b69 Compare April 27, 2022 22:14
@ebyhr ebyhr merged commit b5b462f into trinodb:master Apr 28, 2022
@github-actions github-actions bot added this to the 379 milestone Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Document field quote example for MongoDB _schema collection

3 participants