Add PushDownDereferencesThroughMarkDistinct rule to optimizer#8962
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Oct 28, 2022
Merged
Conversation
phd3
approved these changes
Aug 25, 2021
Member
phd3
left a comment
There was a problem hiding this comment.
😮
Is there an easy-to-add test (i.e. in TestDereferencePushDown) if we've identified issue with a particular query?
I'm not sure what is our general policy for e2e plan tests for optimizer rules, but that could've saved us here. Since the rule has a test, I'm fine with merging this as is.
Member
Member
Author
PushDownDereferencesThroughMarkDistinct was missing from list of rules.
8dfd89f to
a0e6483
Compare
Member
|
Does this have a tangible user impact / does it need a release note? |
Member
Author
It can impact performance some obscure queries for which pushdown would not happen without hte change. But it is not anything substantial, and also would be super hard to percisly describe it in RN. Let's skip it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As spotted by @kasiafi
PushDownDereferencesThroughMarkDistinctwas missing from the list of rules.Likely an omission.