Propagate exception when reading metadata fails#8951
Merged
findepi merged 4 commits intotrinodb:masterfrom Aug 24, 2021
Merged
Conversation
`.suppressFailureWhenFinished()` causes the `run` method return `false` on failure, instead of throwing. This behavior was not desirable here, leading to NPE when trying to access the result.
losipiuk
approved these changes
Aug 24, 2021
Member
Author
|
CI #8691 |
findepi
deleted the
findepi/propagate-exception-when-reading-metadata-fails-a43646
branch
v-jizhang
added a commit
to v-jizhang/presto
that referenced
this pull request
Dec 7, 2021
Cherry-pick of trinodb/trino#8951 Quote rom the original PR: `.suppressFailureWhenFinished()` causes the `run` method return `false` on failure, instead of throwing. This behavior was not desirable here, leading to NPE when trying to access the result. Co-authored-by: Piotr Findeisen <piotr.findeisen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.suppressFailureWhenFinished()causes therunmethod returnfalseon failure, instead of throwing. This behavior was not desirable here,
leading to NPE when trying to access the result.
For #8873