Implement renameSchema for JDBC based connectors#8939
Merged
hashhar merged 3 commits intotrinodb:masterfrom Jan 13, 2022
Merged
Implement renameSchema for JDBC based connectors#8939hashhar merged 3 commits intotrinodb:masterfrom
hashhar merged 3 commits intotrinodb:masterfrom
Conversation
findepi
reviewed
Aug 23, 2021
testing/trino-testing/src/main/java/io/trino/testing/TestingConnectorBehavior.java
Outdated
Show resolved
Hide resolved
If a connector doesn't support creating schemas it's not possible to test if it supports renaming schemas. So to ensure test results aren't misleading enforce that connectors that don't support schema creation assume that schema rename isn't supported. The assumption is explicitly validated so where needed it can be overridden by the connector.
hashhar
force-pushed
the
hashhar/jdbc-rename-schema
branch
from
dc77281 to
08a9452
Compare
ebyhr
approved these changes
Jan 12, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please run all tests for MemSQL just in case. Looks fine as far as I confirmed though.
I think "SQL support" in redshift.rst needs update.
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/ClickHouseClient.java
Show resolved
Hide resolved
This was referenced Jan 12, 2022
Closed
Member
Author
|
@ebyhr Pushed a commit with updated docs and a fixup. PTAL. |
ebyhr
approved these changes
Jan 12, 2022
Member
Author
|
Squashing the fixup. |
hashhar
force-pushed
the
hashhar/jdbc-rename-schema
branch
from
c95623d to
299ebb9
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.