Add session refresh interval in Cassandra connector#8884
Add session refresh interval in Cassandra connector#8884ebyhr wants to merge 3 commits intotrinodb:masterfrom
Conversation
32f4b59 to
e3543d1
Compare
e3543d1 to
2431004
Compare
hashhar
left a comment
There was a problem hiding this comment.
Can you mention in 2nd commit's message that it's to make it work with Yugabyte CQL tables?
Also, some recommendation in docs to enable set a session refresh interval when connecting to Yugabyte would be helpful.
LGTM otherwise.
|
@findinpath Can you test if we need this config properties for Yugabyte CQL even after #7828? |
|
@ebyhr I rebased your changes on top of the cassandra v4 changes and created a new branch It doesn't quite work out of the box.
After doing the change: |
|
@findinpath Thanks! Let me close this PR because it would be better to add the dedicated connector for Yugabyte. This change might be still required when adding the connector, but I wouldn't merge at this time. |
Fixes #4838
I considered extending BaseConnectorTest and BaseConnectorSmokeTest for Yugabyte tests at first, but there were some failures due to lack of
commenttable properties in Yugabyte. Cassandra connector usescommentto mange hidden columns.Also, excluded the logic to populate TPCH data in Yugabyte query runner because it was flaky, returning the wrong row number just after insert.