Merged
Conversation
Member
|
Can this commit be standalone? |
findepi
approved these changes
Aug 3, 2021
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
"Remove unnecessary config" lgtm
Product tests use spark runtime 0.11.0 now, which has fixes for the bugs causing incorrect file size metadata
phd3
force-pushed
the
remove-test-config
branch
from
02654ef to
0773733
Compare
Member
Author
|
@electrum yes, it can be standalone. however, #8751 improves coverage of trino-spark compatibility testing by including both Parquet and ORC. So just wanted to make sure that all tests succeed for both the formats when we remove this config. That was indeed the case: https://github.com/trinodb/trino/actions/runs/1092067327. Removed the commits borrowed from #8751 now. |
Member
Author
|
Merged #8753. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product tests use spark runtime 0.11.0 now, which
has fixes for the bugs causing incorrect file size
metadata