Skip to content

Remove Flaky annotation on tests expected to work#8685

Merged
findepi merged 1 commit intotrinodb:masterfrom
phd3:cleanup2
Jul 29, 2021
Merged

Remove Flaky annotation on tests expected to work#8685
findepi merged 1 commit intotrinodb:masterfrom
phd3:cleanup2

Conversation

@phd3
Copy link
Copy Markdown
Member

@phd3 phd3 commented Jul 27, 2021

#4864 seems like a duplicate of #5201.

@cla-bot cla-bot bot added the cla-signed label Jul 27, 2021
@phd3 phd3 requested review from electrum and findepi July 27, 2021 22:12
@hashhar
Copy link
Copy Markdown
Member

hashhar commented Jul 28, 2021

Copy link
Copy Markdown
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is just a left over after a244d3d, it may not need stress testing.

@hashhar wdyt?

@hashhar
Copy link
Copy Markdown
Member

hashhar commented Jul 28, 2021

The beginning of the stack-trace look different between #4864 and #5201 so I'm not 100% sure the cause is same but it could be the same.

@phd3
Copy link
Copy Markdown
Member Author

phd3 commented Jul 29, 2021

#4864 shows an additional warning given by iceberg finalizer code that contains the stacktrace to indicate the codepath that creates streams that weren't explicitly closed. I've also seen the same while debugging #5201, but somehow not added on the issue. I think it should be safe to get this in, since #8504 was stress-tested.

@findepi
Copy link
Copy Markdown
Member

findepi commented Jul 29, 2021

@hashhar thumbed up, so merging.

@findepi findepi merged commit c5c6968 into trinodb:master Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants