Test ALTER TABLE .. RENAME for Iceberg#8640
Merged
findepi merged 2 commits intotrinodb:masterfrom Jul 23, 2021
Merged
Conversation
findepi
force-pushed
the
findepi/iceberg-rename
branch
from
1afcac3 to
ba8a482
Compare
Member
Author
|
cc @aczajkowski |
phd3
approved these changes
Jul 22, 2021
Member
There was a problem hiding this comment.
can we add a comment saying that we do this for metadata referencing the old path?
...trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergRenameTable.java
Outdated
Show resolved
Hide resolved
This increases non-product test test coverage for Iceberg. Added benefit is that declared connector behavior is now correct.
findepi
force-pushed
the
findepi/iceberg-rename
branch
from
f7c3832 to
da4ac47
Compare
Member
Author
|
thanks @phd3 for the review updated |
phd3
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @alexjo2144