Rename 'insert.batch-size' configuration property into 'write.batch-size'#8609
Merged
hashhar merged 1 commit intotrinodb:masterfrom Jul 23, 2021
Merged
Conversation
hashhar
approved these changes
Jul 20, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % documentation?
Does the documentation also need an update? Or this is not yet documented?
Member
|
thanks!
session -> configuration |
findepi
reviewed
Jul 20, 2021
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java
Outdated
Show resolved
Hide resolved
sergey-melnychuk
changed the title
sergey-melnychuk
force-pushed
the
sm/rename-batch-size
branch
from
317e570 to
a1e309a
Compare
hashhar
approved these changes
Jul 23, 2021
hashhar
force-pushed
the
sm/rename-batch-size
branch
from
a1e309a to
1e91b2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.