Move AggregateFunctionRewriter to plugin toolkit#8578
Merged
hashhar merged 1 commit intotrinodb:masterfrom Aug 21, 2021
Merged
Conversation
This is to make it reusable between connectors based on base-jdbc and the Pinot connector.
elonazoulay
suggested changes
Jul 16, 2021
...rino-plugin-toolkit/src/main/java/io/trino/plugin/base/expression/AggregateFunctionRule.java
Show resolved
Hide resolved
findepi
requested review from
hashhar and
wendigo
and removed request for
hashhar
hashhar
approved these changes
Aug 19, 2021
wendigo
approved these changes
Aug 19, 2021
findepi
deleted the
findepi/move-aggregatefunctionrewriter-to-plugin-toolkit-eabd84
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to make it reusable between connectors based on base-jdbc and
the Pinot connector.
For #6069