Skip to content

Update SQL Server docker images to use the new repository #8416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 1 commit into from
Jun 29, 2021
Merged

Update SQL Server docker images to use the new repository #8416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions plugin/trino-sqlserver/src/test/java/io/trino/plugin/sqlserver/TestingSqlServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ public final class TestingSqlServer
event.getAttemptCount(),
event.getLastFailure().getMessage()));

private static final DockerImageName DOCKER_IMAGE_NAME = DockerImageName.parse("microsoft/mssql-server-linux:2017-CU13")
.asCompatibleSubstituteFor("mcr.microsoft.com/mssql/server:2017-CU12");
private static final DockerImageName DOCKER_IMAGE_NAME = DockerImageName.parse("mcr.microsoft.com/mssql/server:2017-CU13");

private final MSSQLServerContainer<?> container;
private final String databaseName;
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-sqlserver/src/test/resources/container-license-acceptance.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
microsoft/mssql-server-linux:2017-CU13
mcr.microsoft.com/mssql/server:2017-CU13
2 changes: 1 addition & 1 deletion ...er/src/main/java/io/trino/tests/product/launcher/env/environment/SinglenodeSqlserver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ public void extendEnvironment(Environment.Builder builder)
@SuppressWarnings("resource")
private DockerContainer createSqlServer()
{
DockerContainer container = new DockerContainer("microsoft/mssql-server-linux:2017-CU13", "sqlserver")
DockerContainer container = new DockerContainer("mcr.microsoft.com/mssql/server:2017-CU13", "sqlserver")
.withEnv("ACCEPT_EULA", "Y")
.withEnv("SA_PASSWORD", "SQLServerPass1")
.withStartupCheckStrategy(new IsRunningStartupCheckStrategy())
Expand Down
2 changes: 1 addition & 1 deletion testing/trino-product-tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ groups.
Below is a list of commands that explain how to run these profile specific tests
and also the entire test suite:

Note: SQL Server product-tests use `microsoft/mssql-server-linux` docker container.
Note: SQL Server product-tests use `mcr.microsoft.com/mssql/server` docker container.
By running SQL Server product tests you accept the license [ACCEPT_EULA](https://go.microsoft.com/fwlink/?LinkId=746388)

### Running test suites
Expand Down