Merged
Conversation
martint
reviewed
May 26, 2019
Member
There was a problem hiding this comment.
Maybe put this one in the same group as ImplementBernoulliSampleAsFilter
This change is based on RowNumberNode's property of keeping order of its input. In OFFSET implementation, a RowNumberNode and a FilterNode are used for rows selection. Before this change, if there was ORDER BY in the query, it was handled by one of the specialised rules which ensured that sorting was replicated over RowNumberNode. Since RowNumberNode respects sorted order of its input, it is unnecessary to add a SortNode.
kasiafi
force-pushed
the
OffsetImplementation
branch
from
54cfeed to
2fec4bd
Compare
Member
|
Merged, thanks! |
fgwang7w
added a commit
to fgwang7w/presto
that referenced
this pull request
Jun 9, 2021
Cherry-pick of trinodb/trino#732, trinodb/trino#820 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
rongrong
pushed a commit
to prestodb/presto
that referenced
this pull request
Jun 22, 2021
Cherry-pick of trinodb/trino#732, trinodb/trino#820 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
jzzhaofb-zz
pushed a commit
to jzzhaofb-zz/presto
that referenced
this pull request
Jun 29, 2021
Cherry-pick of trinodb/trino#732, trinodb/trino#820 Co-authored-by: kasiafi <30203062+kasiafi@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is based on RowNumberNode's property of keeping order of its input.
In OFFSET implementation, a RowNumberNode and a FilterNode are used for rows selection.
Before this change, if there was ORDER BY in the query, it was handled by one of
the specialised rules which ensured that sorting was replicated over RowNumberNode.
Since RowNumberNode respects sorted order of its input, it is unnecessary to add
a SortNode.