Skip to content

Add DynamicFilter to ConnectorRecordSetProvider SPI #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jerryleooo wants to merge 1 commit into from
Closed

Add DynamicFilter to ConnectorRecordSetProvider SPI #8046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/split/RecordPageSourceProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@ public ConnectorPageSource createPageSource(
List<ColumnHandle> columns,
DynamicFilter dynamicFilter)
{
return new RecordPageSource(recordSetProvider.getRecordSet(transaction, session, split, table, columns));
return new RecordPageSource(recordSetProvider.getRecordSet(transaction, session, split, table, columns, dynamicFilter));
}
}
13 changes: 13 additions & 0 deletions core/trino-spi/src/main/java/io/trino/spi/connector/ConnectorRecordSetProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,19 @@

public interface ConnectorRecordSetProvider
{
default RecordSet getRecordSet(
ConnectorTransactionHandle transaction,
ConnectorSession session,
ConnectorSplit split,
ConnectorTableHandle table,
List<? extends ColumnHandle> columns,
DynamicFilter dynamicFilter)
{
// By default, ignore dynamic filter (as it is an optimization and doesn't affect correctness).
return getRecordSet(transaction, session, split, table, columns);
}

@Deprecated
default RecordSet getRecordSet(
Comment thread
jerryleooo marked this conversation as resolved.
Outdated
ConnectorTransactionHandle transaction,
ConnectorSession session,
Expand Down
7 changes: 7 additions & 0 deletions ...main/java/io/trino/plugin/base/classloader/ClassLoaderSafeConnectorRecordSetProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import io.trino.spi.connector.ConnectorSplit;
import io.trino.spi.connector.ConnectorTableHandle;
import io.trino.spi.connector.ConnectorTransactionHandle;
import io.trino.spi.connector.DynamicFilter;
import io.trino.spi.connector.RecordSet;

import javax.inject.Inject;
Expand All @@ -42,6 +43,12 @@ public ClassLoaderSafeConnectorRecordSetProvider(@ForClassLoaderSafe ConnectorRe
this.classLoader = requireNonNull(classLoader, "classLoader is null");
}

@Override
public RecordSet getRecordSet(ConnectorTransactionHandle transaction, ConnectorSession session, ConnectorSplit split, ConnectorTableHandle table, List<? extends ColumnHandle> columns, DynamicFilter dynamicFilter)
{
return getRecordSet(transaction, session, split, table, columns);
}

@Override
public RecordSet getRecordSet(ConnectorTransactionHandle transaction, ConnectorSession session, ConnectorSplit split, ConnectorTableHandle table, List<? extends ColumnHandle> columns)
{
Expand Down