Migrate Thrift connector tests to use BaseConnectorTest #7117#7975
Closed
xuboqing wants to merge 1 commit intotrinodb:masterfrom
Closed
Migrate Thrift connector tests to use BaseConnectorTest #7117#7975xuboqing wants to merge 1 commit intotrinodb:masterfrom
xuboqing wants to merge 1 commit intotrinodb:masterfrom
Conversation
creating a pull request for issue trinodb#7117 to fix trinodb#7117
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
hashhar
reviewed
Jun 30, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Overall looks good % some comments.
| @@ -0,0 +1,100 @@ | |||
| /* | |||
|
|
||
| public class TestThriftIntegrationSmokeTest | ||
| public class TestThriftConnectorTest | ||
| // TODO extend BaseConnectorTest |
Member
There was a problem hiding this comment.
Remove the TODO since it seems adressed now.
| } | ||
|
|
||
| @Test | ||
| public void testCreateArrayTable() |
Member
There was a problem hiding this comment.
Add these in a new commit since they are new tests not part of either the existing smoke test or the distributed queries test.
Member
|
Closing as #10233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creating a pull request for issue #7117 to fix #7117