Simplify transactions in JdbcPageSink#7875
Merged
findepi merged 5 commits intotrinodb:masterfrom May 10, 2021
Merged
Conversation
kokosing
approved these changes
May 10, 2021
kokosing
reviewed
May 10, 2021
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcPageSink.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/less-autocommit
branch
from
bd8df50 to
04b3412
Compare
losipiuk
approved these changes
May 10, 2021
This ensures the Phoenix connector cannot be used in some unsupported manner, should some other JDBC driver be presented on the classpath.
findepi
force-pushed
the
findepi/less-autocommit
branch
from
04b3412 to
a2655f7
Compare
Per JDBC spec, a Driver is expected to have new connections in auto-commit mode. This seems not to be true for `PhoenixDriver`.
findepi
force-pushed
the
findepi/less-autocommit
branch
from
a2655f7 to
5aa8001
Compare
ksobolew
reviewed
May 10, 2021
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcPageSink.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/less-autocommit
branch
3 times, most recently
from
9c4b433 to
2a9c887
Compare
Explicit transaction management was unnecessary there, since there was always exactly one statement (`executeBatch`) executed within each transaction. Leveraging auto-commit allows for simpler code.
findepi
force-pushed
the
findepi/less-autocommit
branch
from
2a9c887 to
2011c8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.