handle InvalidCodePointException#7731
handle InvalidCodePointException#7731JoJoBizarreAdventure wants to merge 0 commit intotrinodb:masterfrom JoJoBizarreAdventure:testChar
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
It seems there is a conflict. Shall I change the nCopies() one to using toAdd? |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
1 similar comment
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Thanks.
Please squash the commits. We prefer to keep the fix and tests in the same commit to help when bisecting.
There was a problem hiding this comment.
Either use constants if there are (or create them) or use the hex representation with a comment about the significance of these values.
There was a problem hiding this comment.
ok, I will change it to hex reperesentation
There was a problem hiding this comment.
Sorry, I'm not really familiar with git, I'm making try to make it right
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla. |
2 participants
A pull request for #7597
Handling cases for codePoint is 0xE000
Using keep decreasing result 0xD7FF as the modified code point instead of 0xDFFF