Skip to content

Add operator cache and coercion cache to reduce planning time #7556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 2 commits into from
Apr 16, 2021
Merged

Add operator cache and coercion cache to reduce planning time #7556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fb217c
Add large IN predicate test in planner benchmark
lzeiming Apr 1, 2021
160fc4e
Add operator cache and coercion cache in metadata manager
lzeiming Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
141 changes: 132 additions & 9 deletions core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,15 @@

import com.google.common.annotations.VisibleForTesting;
Comment thread
lzeiming marked this conversation as resolved.
Outdated
import com.google.common.base.Joiner;
import com.google.common.cache.CacheBuilder;
import com.google.common.cache.CacheLoader;
import com.google.common.cache.LoadingCache;
import com.google.common.collect.HashMultimap;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Multimap;
import com.google.common.util.concurrent.UncheckedExecutionException;
import io.airlift.slice.Slice;
import io.trino.Session;
import io.trino.client.NodeVersion;
Expand Down Expand Up @@ -201,6 +205,9 @@ public final class MetadataManager

private final ResolvedFunctionDecoder functionDecoder;

private final LoadingCache<OperatorCacheKey, ResolvedFunction> operatorCache;
private final LoadingCache<CoercionCacheKey, ResolvedFunction> coercionCache;

@Inject
public MetadataManager(
FeaturesConfig featuresConfig,
Expand Down Expand Up @@ -248,6 +255,23 @@ public MetadataManager(
verifyTypes();

functionDecoder = new ResolvedFunctionDecoder(this::getType);

operatorCache = CacheBuilder.newBuilder()
.maximumSize(1000)
.build(CacheLoader.from(key -> {
String name = mangleOperatorName(key.getOperatorType());
return resolveFunction(QualifiedName.of(name), fromTypes(key.getArgumentTypes()));
}));

coercionCache = CacheBuilder.newBuilder()
.maximumSize(1000)
Comment thread
sopel39 marked this conversation as resolved.
Outdated
Comment thread
sopel39 marked this conversation as resolved.
Outdated
.build(CacheLoader.from(key -> {
String name = mangleOperatorName(key.getOperatorType());
Type fromType = key.getFromType();
Type toType = key.getToType();
Signature signature = new Signature(name, toType.getTypeSignature(), ImmutableList.of(fromType.getTypeSignature()));
return resolve(functionResolver.resolveCoercion(functions.get(QualifiedName.of(name)), signature));
Comment thread
sopel39 marked this conversation as resolved.
Outdated
}));
}

public static MetadataManager createTestMetadataManager()
Expand Down Expand Up @@ -1884,11 +1908,15 @@ public ResolvedFunction resolveOperator(OperatorType operatorType, List<? extend
throws OperatorNotFoundException
{
try {
return resolveFunction(QualifiedName.of(mangleOperatorName(operatorType)), fromTypes(argumentTypes));
return operatorCache.getUnchecked(new OperatorCacheKey(operatorType, argumentTypes));
}
catch (TrinoException e) {
if (e.getErrorCode().getCode() == FUNCTION_NOT_FOUND.toErrorCode().getCode()) {
throw new OperatorNotFoundException(operatorType, argumentTypes, e);
catch (UncheckedExecutionException e) {
if (e.getCause() instanceof TrinoException) {
TrinoException cause = (TrinoException) e.getCause();
if (cause.getErrorCode().getCode() == FUNCTION_NOT_FOUND.toErrorCode().getCode()) {
throw new OperatorNotFoundException(operatorType, argumentTypes, cause);
}
throw cause;
}
throw e;
}
Expand All @@ -1899,12 +1927,15 @@ public ResolvedFunction getCoercion(OperatorType operatorType, Type fromType, Ty
{
checkArgument(operatorType == OperatorType.CAST || operatorType == OperatorType.SATURATED_FLOOR_CAST);
try {
String name = mangleOperatorName(operatorType);
return resolve(functionResolver.resolveCoercion(functions.get(QualifiedName.of(name)), new Signature(name, toType.getTypeSignature(), ImmutableList.of(fromType.getTypeSignature()))));
return coercionCache.getUnchecked(new CoercionCacheKey(operatorType, fromType, toType));
}
catch (TrinoException e) {
if (e.getErrorCode().getCode() == FUNCTION_IMPLEMENTATION_MISSING.toErrorCode().getCode()) {
throw new OperatorNotFoundException(operatorType, ImmutableList.of(fromType), toType.getTypeSignature(), e);
catch (UncheckedExecutionException e) {
if (e.getCause() instanceof TrinoException) {
TrinoException cause = (TrinoException) e.getCause();
if (cause.getErrorCode().getCode() == FUNCTION_IMPLEMENTATION_MISSING.toErrorCode().getCode()) {
throw new OperatorNotFoundException(operatorType, ImmutableList.of(fromType), toType.getTypeSignature(), cause);
}
throw cause;
}
throw e;
}
Expand Down Expand Up @@ -2314,4 +2345,96 @@ private synchronized void finish()
}
}
}

private static class OperatorCacheKey
{
private final OperatorType operatorType;
private final List<? extends Type> argumentTypes;

private OperatorCacheKey(OperatorType operatorType, List<? extends Type> argumentTypes)
{
this.operatorType = requireNonNull(operatorType, "operatorType is null");
this.argumentTypes = ImmutableList.copyOf(requireNonNull(argumentTypes, "argumentTypes is null"));
}

public OperatorType getOperatorType()
{
return operatorType;
}

public List<? extends Type> getArgumentTypes()
{
return argumentTypes;
}

@Override
public int hashCode()
{
return Objects.hash(operatorType, argumentTypes);
}

@Override
public boolean equals(Object obj)
{
if (this == obj) {
return true;
}
if (!(obj instanceof OperatorCacheKey)) {
return false;
}
OperatorCacheKey other = (OperatorCacheKey) obj;
return Objects.equals(this.operatorType, other.operatorType) &&
Objects.equals(this.argumentTypes, other.argumentTypes);
}
}

private static class CoercionCacheKey
{
private final OperatorType operatorType;
private final Type fromType;
private final Type toType;

private CoercionCacheKey(OperatorType operatorType, Type fromType, Type toType)
{
this.operatorType = requireNonNull(operatorType, "operatorType is null");
this.fromType = requireNonNull(fromType, "fromType is null");
this.toType = requireNonNull(toType, "toType is null");
}

public OperatorType getOperatorType()
{
return operatorType;
}

public Type getFromType()
{
return fromType;
}

public Type getToType()
{
return toType;
}

@Override
public int hashCode()
{
return Objects.hash(operatorType, fromType, toType);
}

@Override
public boolean equals(Object obj)
{
if (this == obj) {
return true;
}
if (!(obj instanceof CoercionCacheKey)) {
return false;
}
CoercionCacheKey other = (CoercionCacheKey) obj;
return Objects.equals(this.operatorType, other.operatorType) &&
Objects.equals(this.fromType, other.fromType) &&
Objects.equals(this.toType, other.toType);
}
}
}
21 changes: 21 additions & 0 deletions core/trino-main/src/test/java/io/trino/sql/planner/BenchmarkPlanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import io.trino.plugin.tpch.TpchConnectorFactory;
import io.trino.testing.LocalQueryRunner;
import io.trino.tpch.Customer;
import org.intellij.lang.annotations.Language;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
Expand Down Expand Up @@ -53,7 +54,9 @@
import static io.trino.testing.TestingSession.testSessionBuilder;
import static java.lang.String.format;
import static java.util.Locale.ENGLISH;
import static java.util.stream.Collectors.joining;
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNotNull;

@SuppressWarnings("MethodMayBeStatic")
@State(Scope.Benchmark)
Expand All @@ -73,6 +76,8 @@ public static class BenchmarkData

private LocalQueryRunner queryRunner;
private List<String> queries;
@Language("SQL")
private String largeInQuery;
private Session session;

@Setup
Expand All @@ -93,6 +98,11 @@ public void setup()
.filter(i -> i != 15) // q15 has two queries in it
.map(i -> readResource(format("/io/trino/tpch/queries/q%d.sql", i)))
.collect(toImmutableList());

largeInQuery = "SELECT * from orders where o_orderkey in " +
IntStream.range(0, 5000)
.mapToObj(Integer::toString)
.collect(joining(", ", "(", ")"));
}

@TearDown
Expand Down Expand Up @@ -125,13 +135,24 @@ public List<Plan> planQueries(BenchmarkData benchmarkData)
});
}

@Benchmark
public Plan planLargeInQuery(BenchmarkData benchmarkData)
Comment thread
lzeiming marked this conversation as resolved.
Outdated
{
return benchmarkData.queryRunner.inTransaction(transactionSession -> {
LogicalPlanner.Stage stage = LogicalPlanner.Stage.valueOf(benchmarkData.stage.toUpperCase(ENGLISH));
return benchmarkData.queryRunner.createPlan(
transactionSession, benchmarkData.largeInQuery, stage, false, WarningCollector.NOOP);
});
}

@Test
public void verify()
{
BenchmarkData data = new BenchmarkData();
data.setup();
BenchmarkPlanner benchmark = new BenchmarkPlanner();
assertEquals(benchmark.planQueries(data).size(), 21);
assertNotNull(benchmark.planLargeInQuery(data));
}

public static void main(String[] args)
Expand Down