Conversation
There was a problem hiding this comment.
@Praveen2112 There is an extra file in your commit (presto-main/hs_err_pid39366.log) that I don't think you intended to add.
|
@pgagnon Thanks for pointing it out. Have removed it. |
electrum
left a comment
There was a problem hiding this comment.
Did a quick review and it looks good. Please add this to the types documentation, like IP address.
presto-main/src/test/java/io/prestosql/type/TestUUIDOperators.java
Outdated
Show resolved
Hide resolved
|
@electrum any thoughts on what we do about the existing |
There was a problem hiding this comment.
For acronyms, we capitalize the first letter and use lower case for the rest when used in class or method names (URL -> Url, HTTP -> Http). So, in this case: UuidOperators
There was a problem hiding this comment.
Moved to the above format
|
@dain I’m didn’t know that existed, and it’s not documented. We could replace it with a function that returns the new type. PostgreSQL has more specifically named functions like |
presto-main/src/test/java/io/prestosql/type/TestUuidOperators.java
Outdated
Show resolved
Hide resolved
af2c898 to
9f39502
Compare
|
@electrum Have handled all the commits. Please let me know if there are any more changes. |
|
Merged, thanks! |
Cherry-pick of trinodb/trino#755. Co-authored-by: praveenkrishna <praveenkrishna@tutanota.com>
Cherry-pick of trinodb/trino#755. Co-authored-by: praveenkrishna <praveenkrishna@tutanota.com>
No description provided.