Skip to content

Comments

Document JDBC parameters disableCompression, assumeLiteralNamesInMetadataCallsForNonConformingClients#7458

Merged
findepi merged 3 commits intotrinodb:masterfrom
findepi:findepi/jdbc-doc
Apr 7, 2021
Merged

Document JDBC parameters disableCompression, assumeLiteralNamesInMetadataCallsForNonConformingClients#7458
findepi merged 3 commits intotrinodb:masterfrom
findepi:findepi/jdbc-doc

Conversation

@findepi
Copy link
Member

@findepi findepi commented Mar 30, 2021

No description provided.

@findepi findepi added the docs label Mar 30, 2021
@findepi findepi requested review from electrum and losipiuk March 30, 2021 12:00
@cla-bot cla-bot bot added the cla-signed label Mar 30, 2021
@findepi findepi requested a review from sopel39 March 31, 2021 14:00
``externalAuthentication`` Use a local web browser to authenticate with an identity provider (IdP)
that has been configured for the Trino coordinator.
See :doc:`/security/oauth2` for more details.
``disableCompression`` Whether compression should be enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of compression? Why would anyone disable it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message too long

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the toggle name is intentionally long and it would be useless to omit it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what it means and what it does :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you improve description here? I doubt whoever reads the doc will be able to find mentioned issues

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to get the description as good as i can. Please let me know what you would want me to include here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add explanation brief explanation when to enable it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding

You can use this as a workaround for
applications that do not escape schema or table names when passing them
to DatabaseMetaData methods as schema or table name patterns.

from RNs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@findepi findepi force-pushed the findepi/jdbc-doc branch from 9b8092e to 6840d5b Compare April 7, 2021 19:50
@findepi findepi requested a review from sopel39 April 7, 2021 19:50
@findepi findepi force-pushed the findepi/jdbc-doc branch from 6840d5b to 1a73e1a Compare April 7, 2021 20:30
@findepi findepi merged commit ef630ac into trinodb:master Apr 7, 2021
@findepi findepi deleted the findepi/jdbc-doc branch April 7, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants