Skip to content

FutureTask replaces CompletableFuture to solve the thread can't be cancelled#7404

Closed
iodone wants to merge 1 commit intotrinodb:masterfrom
iodone:trino-jdbc-resultset-replace-completableFuture
Closed

FutureTask replaces CompletableFuture to solve the thread can't be cancelled#7404
iodone wants to merge 1 commit intotrinodb:masterfrom
iodone:trino-jdbc-resultset-replace-completableFuture

Conversation

@iodone
Copy link
Copy Markdown

@iodone iodone commented Mar 24, 2021

Fixes #7374

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 24, 2021

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: zhangyaodong.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@findepi findepi requested a review from lhofhansl March 24, 2021 08:56
@iodone iodone force-pushed the trino-jdbc-resultset-replace-completableFuture branch from 8f5e0e2 to 9264b59 Compare March 25, 2021 01:25
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 25, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@iodone iodone force-pushed the trino-jdbc-resultset-replace-completableFuture branch from 9264b59 to 32fac2a Compare April 6, 2021 06:45
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Apr 6, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@braiscouce
Copy link
Copy Markdown

Do yo know when this will be merged?

@martint
Copy link
Copy Markdown
Member

martint commented Aug 19, 2022

Sorry for the long delay, it appears we lost track of this PR.

@iodone, can you add a test?

@xiacongling
Copy link
Copy Markdown
Contributor

xiacongling commented Aug 22, 2022

Hi, @findepi , @martint . @iodone is engaged in other projects these days. After a short discuss with him, I think I can continue his work with the new PR #13775 . Please have a look at it. Thanks.

@iodone iodone closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

In Trino-JDBC calling TrinoResultSet.cancel can't really close completablaFuture thread

4 participants