Disallow use of implicit types in remote databases in type tests#7245
Merged
findepi merged 2 commits intotrinodb:masterfrom Mar 11, 2021
Merged
Disallow use of implicit types in remote databases in type tests#7245findepi merged 2 commits intotrinodb:masterfrom
findepi merged 2 commits intotrinodb:masterfrom
Conversation
findepi
force-pushed
the
findepi/enforce-explicit-types
branch
from
c0c82c6 to
e4676f4
Compare
findepi
force-pushed
the
findepi/enforce-explicit-types
branch
2 times, most recently
from
2a7ad29 to
6931b24
Compare
jirassimok
approved these changes
Mar 10, 2021
Member
jirassimok
left a comment
jirassimok
left a comment
There was a problem hiding this comment.
That last push addressed my only big comment before I finished writing it; very nice.
Looks good; just a grammar fix and two small suggestions.
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlTypeMapping.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/datatype/CreateAndInsertDataSetup.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/datatype/CreateAndInsertDataSetup.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/enforce-explicit-types
branch
from
6931b24 to
203696b
Compare
Member
Author
|
AC, changed comment & message |
jirassimok
approved these changes
Mar 11, 2021
Member
jirassimok
left a comment
jirassimok
left a comment
There was a problem hiding this comment.
This is a very nice improvement.
sopel39
approved these changes
Mar 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7166 (comment)