Fix id based mapping for non-lowercase fields#7180
Merged
phd3 merged 3 commits intotrinodb:masterfrom Mar 6, 2021
Merged
Conversation
findepi
approved these changes
Mar 5, 2021
testing/trino-product-tests/src/main/java/io/trino/tests/iceberg/TestSparkCompatibility.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Jul 30, 2021
Comment on lines
+3
to
+4
| # TODO: Remove this config to test default read behavior once Spark writer version is fixed. See https://github.com/trinodb/trino/issues/6369 for details | ||
| iceberg.use-file-size-from-metadata=false |
Member
There was a problem hiding this comment.
Can this be removed now?
if Spark Iceberg still writes incorrect file sizes, we should reconsider whether iceberg.use-file-size-from-metadata shouldn't be false by default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue discussed in Slack thread. The change in #6520 causes nested column reads on ORC files to fail when they have non-lowercase field names.
The added test here fails without this change with a similar stacktrace.