Introduce common connector test for JDBC connectors#7139
Merged
findepi merged 3 commits intotrinodb:masterfrom Mar 4, 2021
Merged
Conversation
hashhar
reviewed
Mar 3, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
A good template to get started.
But I notice that a lot of Jdbc connectors are not plugged into this in this PR. Intentional?
losipiuk
approved these changes
Mar 3, 2021
Member
Hopefully all which migrated to |
hashhar
approved these changes
Mar 3, 2021
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM.
Only Redis is missing but that's not based on Jdbc. 👍
kokosing
approved these changes
Mar 3, 2021
Member
Author
i migrated only the ones already on BCT i will rebase to include two more that i just merged |
findepi
force-pushed
the
findepi/introduce-common-connector-test-for-jdbc-connectors-142fdb
branch
from
80162b7 to
86efa58
Compare
losipiuk
approved these changes
Mar 3, 2021
findepi
force-pushed
the
findepi/introduce-common-connector-test-for-jdbc-connectors-142fdb
branch
from
86efa58 to
836bf34
Compare
kokosing
approved these changes
Mar 4, 2021
The connectors based on base-jdbc share a lot of common functionality and tests, so they will benefit from common test code as well.
findepi
force-pushed
the
findepi/introduce-common-connector-test-for-jdbc-connectors-142fdb
branch
from
836bf34 to
9777857
Compare
findepi
deleted the
findepi/introduce-common-connector-test-for-jdbc-connectors-142fdb
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The connectors based on base-jdbc share a lot of common functionality
and tests, so they will benefit from common test code as well.
Extracted from #6874