Skip to content

Add docs for preferred-write-partitioning-min-number-of-partitions#7119

Merged
sopel39 merged 1 commit intotrinodb:masterfrom
skrzypo987:skrzypo/023-pwp-threshold-docs
Mar 8, 2021
Merged

Add docs for preferred-write-partitioning-min-number-of-partitions#7119
sopel39 merged 1 commit intotrinodb:masterfrom
skrzypo987:skrzypo/023-pwp-threshold-docs

Conversation

@skrzypo987
Copy link
Copy Markdown
Member

@skrzypo987 skrzypo987 commented Mar 2, 2021

docs for #6920

@cla-bot cla-bot bot added the cla-signed label Mar 2, 2021
@skrzypo987 skrzypo987 requested review from mosabua and sopel39 March 2, 2021 12:55
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase it too The minimum number of written partitions that is required to use connector preferred write partitioning. If the number of partitions cannot be estimated from the statistics, then preferred write partitioning is not used. If the threshold value is less then or equal to 1 then preferred write partitioning is always used

@skrzypo987 skrzypo987 force-pushed the skrzypo/023-pwp-threshold-docs branch from 05edaa6 to 6947313 Compare March 3, 2021 09:10
@skrzypo987
Copy link
Copy Markdown
Member Author

Made a change suggested by @sopel39 .
@mosabua it is your turn.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two mini changes and then good to go.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is always used.

(end of sentence dot..)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either

equal to one

or

equal to ``1``

@skrzypo987 skrzypo987 force-pushed the skrzypo/023-pwp-threshold-docs branch from 6947313 to f2e4426 Compare March 4, 2021 06:33
@skrzypo987
Copy link
Copy Markdown
Member Author

Applied remarks and changed less then to less than

@sopel39 sopel39 merged commit fd7e933 into trinodb:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants