Skip to content

Add docs for 'use-preferred-write-partitioning'#7043

Merged
sopel39 merged 1 commit intotrinodb:masterfrom
skrzypo987:skrzypo/020-preferred-partitioning-docs
Mar 2, 2021
Merged

Add docs for 'use-preferred-write-partitioning'#7043
sopel39 merged 1 commit intotrinodb:masterfrom
skrzypo987:skrzypo/020-preferred-partitioning-docs

Conversation

@skrzypo987
Copy link
Copy Markdown
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Feb 26, 2021
@skrzypo987 skrzypo987 requested a review from mosabua February 26, 2021 08:48
Copy link
Copy Markdown
Member

@sopel39 sopel39 Feb 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add:
As a result, for some connectors (e.g Hive) a single new file per partition will be created instead of multiple ones. Partition writer assignments are distributed across worker nodes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@skrzypo987 skrzypo987 force-pushed the skrzypo/020-preferred-partitioning-docs branch from 17c6b80 to 3e88c72 Compare February 26, 2021 10:13
Copy link
Copy Markdown
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mosabua PTAL

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid future tense, commas and such .. how about something like this

Enable preferred write partitioning. When set to ``true`` each partition is written be a separate writer. As a result, for some connectors such as the Hive connector, only a single new file is written per partition, instead of multiple files. Partition writer assignments are distributed across worker nodes for parallel processing.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose an improve, and hopefully correct version. Please take all of it or parts into account .

@skrzypo987 skrzypo987 force-pushed the skrzypo/020-preferred-partitioning-docs branch from 3e88c72 to 60db37c Compare March 1, 2021 08:46
@skrzypo987
Copy link
Copy Markdown
Member Author

Redacted (copy-pasted) according to @mosabua remarks

@skrzypo987 skrzypo987 force-pushed the skrzypo/020-preferred-partitioning-docs branch from 60db37c to 9d6fa79 Compare March 1, 2021 10:48
@sopel39 sopel39 merged commit 8dab174 into trinodb:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants